Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race when pushing quickly several times to a PR #34

Open
Zimmi48 opened this issue May 6, 2019 · 0 comments
Open

Possible race when pushing quickly several times to a PR #34

Zimmi48 opened this issue May 6, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@Zimmi48
Copy link
Member

Zimmi48 commented May 6, 2019

People can push quickly several times to a PR, especially when using GitHub's suggestion feature, and applying suggestions. If the make-ancestor.sh script is run several times in parallel for the same PR, the script can fail with:

fatal: 'pr-10002' is already checked out at '/tmp/tmp.oKe1DcAZKW'

leading to a wrong conclusion that the current PR cannot be merged with the base branch.

Another race that can also happen in this case is a rebase label being set with a delay. Meanwhile the next push has produced a successful merge which should lead to removing the rebase label if it is set. But it isn't the case yet.

@Zimmi48 Zimmi48 added the bug Something isn't working label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant