Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with coqbot feedback #95

Open
1 of 3 tasks
Zimmi48 opened this issue Aug 25, 2020 · 0 comments
Open
1 of 3 tasks

Merge with coqbot feedback #95

Zimmi48 opened this issue Aug 25, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Zimmi48
Copy link
Member

Zimmi48 commented Aug 25, 2020 •
edited
Loading

Some feedback from coq/coq#12778.

  • The bot does not verify that the PR that it is asked to merge is not already merged nor in draft mode.
  • It would be nice if the bot reported all the (or more than one) unmet conditions rather than quitting at the first unmet condition.
  • Comments are filtered out but code blocks or inline code spans are not. Given the complexity of Markdown rules for code blocks and inline code spans, I don't think we could do this perfectly without relying on a Markdown parsing library (https://github.com/ocaml/omd).
@ticket-tagger ticket-tagger bot added the enhancement New feature or request label Aug 25, 2020
Zimmi48 added a commit to Zimmi48/bot that referenced this issue Sep 16, 2020
@Zimmi48
Batch reasons for not merging.
f9ef33a 
Part of the feedback in coq#95.
Zimmi48 added a commit to Zimmi48/bot that referenced this issue Sep 17, 2020
@Zimmi48
Batch reasons for not merging.
2d774ad 
Part of the feedback in coq#95.
Zimmi48 added a commit to Zimmi48/bot that referenced this issue Sep 17, 2020
@Zimmi48
Batch reasons for not merging.
6fdae32 
Part of the feedback in coq#95.
Zimmi48 added a commit to Zimmi48/bot that referenced this issue Sep 17, 2020
@Zimmi48
Batch reasons for not merging.
ccaf0c6 
Part of the feedback in coq#95.
@Zimmi48 Zimmi48 mentioned this issue Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zimmi48