-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib wastes time being rebuilt on every minimizer run #98
Comments
It is correct to rebuild when coqc changes. |
Perhaps that is true in general, but it should be possible (and relatively easy, without needing to know the details of the build system of any given development) to bypass the rebuild. I don't think it's reasonable to force a rebuild of a development and all its dependencies when testing out a fix. What workflow is this serving? Perhaps actually the issue is that Coq's CI targets should not be using this wrapper? |
I'm going to reopen for now this so it doesn't get lost, feel free to transfer it to coq/coq or ask me to do that |
We can avoid the rebuild by not doing |
The bug minimizer needs to wrap coqc in order to extract information about the build. This means that the hashes are different in
stdlib/dev/with-rocq-wrap.sh
Lines 5 to 18 in 39664f2
which I guess has dune rebuild all files. What's the justification for doing this?
The text was updated successfully, but these errors were encountered: