Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclusion rules for Nextcloud-Recognize module incomplete #100

Open
browsingman opened this issue Nov 17, 2024 · 4 comments · May be fixed by #102
Open

Exclusion rules for Nextcloud-Recognize module incomplete #100

browsingman opened this issue Nov 17, 2024 · 4 comments · May be fixed by #102

Comments

@browsingman
Copy link

Exclusions rules for Nextcloud-Recognize Rule is not working correctly.
The recognise Modul allows renaming Photos to names instead of numbers.

The current rule works correctly if they are only addressed by numbers, but as soon as it is renamed to Names, the exclusion rule does not apply any more and the request is being blocked.
@EsadCetiner
Copy link
Member

@browsingman I'm not sure if you mean something else, but do you mean renaming tagged faces within the photos app? That's the only false positive I can find relating to Photos and Recognize. If your having issues with something else could you provide detailed instructions on how to reproduce it or share your modsec audit log?

@browsingman
Copy link
Author

Yes sorry. I was a bit tired when writing this and English is not my native language. Of course I meant the topic if renaming tagged faces within the photos app. Do you already know what kind of fix could be used or when it will be fixed?

@EsadCetiner EsadCetiner linked a pull request Nov 18, 2024 that will close this issue
Open
@EsadCetiner
Copy link
Member

@browsingman Thanks for confirming, I prepared an PR earlier and I've just opened it now #102

Let me know if it fixes your issue

@browsingman
Copy link
Author

So I applied the fix that you created manually and it does indeed fix the problem ... making me very happy ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: renaming tagged faces in photos app EsadCetiner/nextcloud-rule-exclusions-plugin
2 participants
@browsingman @EsadCetiner