Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potentially wrong jit hints #37

Open
cfbolz opened this issue Aug 26, 2016 · 0 comments
Open

potentially wrong jit hints #37

cfbolz opened this issue Aug 26, 2016 · 0 comments

Comments

@cfbolz
Copy link
Contributor

cfbolz commented Aug 26, 2016

when discussing with @snim2 it occurred to me that the can_enter_jit hint is potentially placed wrong: there must be no code at all between can_enter_jit and jit_merge_point, but in sim.py there is the if s.running condition of the while loop in between:

https://github.com/cornell-brg/pydgin/blob/master/pydgin/sim.py#L145

So it should be restructured to something like this:

    while True:

      jitdriver.jit_merge_point(
        pc        = s.fetch_pc(),
        max_insts = max_insts,
        state     = s,
        sim       = self,
)
      if not s.running:
        break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant