Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some params not getting picked up #611

Open
pyramation opened this issue May 4, 2024 · 1 comment
Open

some params not getting picked up #611

pyramation opened this issue May 4, 2024 · 1 comment

Comments

@pyramation
Copy link
Collaborator

low priority, since it's mostly for LCD, which is technically deprecated

rpc TotalRecvFees(QueryTotalRecvFeesRequest) returns (QueryTotalRecvFeesResponse) {
option (google.api.http).get = "/ibc/apps/fee/v1/channels/{packet_id.channel_id}/ports/{packet_id.port_id}/"
"sequences/{packet_id.sequence}/total_recv_fees";
}

async totalAckFees(_params: QueryTotalAckFeesRequest = {}): Promise<QueryTotalAckFeesResponseSDKType> {
const endpoint = `ibc/apps/fee/v1/channels/${params.packetId.channel_id}/ports/${params.packetId.port_id}/sequences/${params.packetId.sequence}/total_ack_fees`;
return QueryTotalAckFeesResponse.fromSDKJSON(await this.req.get<QueryTotalAckFeesResponseSDKType>(endpoint));

Notice the _params thinks it's empty, but it's NOT:

 async totalAckFees(_params: QueryTotalAckFeesRequest = {}): Promise<QueryTotalAckFeesResponseSDKType> {
    const endpoint = `ibc/apps/fee/v1/channels/${params.packetId.channel_id}/ports/${params.packetId.port_id}/sequences/${params.packetId.sequence}/total_ack_fees`;
    return QueryTotalAckFeesResponse.fromSDKJSON(await this.req.get<QueryTotalAckFeesResponseSDKType>(endpoint));
  }
@pyramation
Copy link
Collaborator Author

I think the path info doesn't know how to deal with {package_id.chain_id} when creating path infos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant