Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x/staking Extending the built-in Module in Cosmos SDK #23706

Open
golnarmordadi opened this issue Feb 14, 2025 · 4 comments
Open

[x/staking Extending the built-in Module in Cosmos SDK #23706

golnarmordadi opened this issue Feb 14, 2025 · 4 comments
Labels
needs-triage Issue that needs to be triaged

Comments

@golnarmordadi
Copy link

Subject: Extending the Staking Module in Cosmos SDK

Hello Cosmos team,

I have a requirement to modify the existing staking module by:

1- Adding a new field to the Validator protobuf definition in staking module.
2- Implementing logic in the staking keeper to check this new field.

However, I want to extend the existing staking keeper rather than creating a separate custom module. Given that our chain references the staking module externally (without having its code locally), is this possible? If so, what would be the best approach to achieve this?

Is there a samle project OR code to direct me?

Looking forward to your guidance.

Best regards,

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Legacy Feb 14, 2025
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 14, 2025
@golnarmordadi golnarmordadi changed the title Extending the built-in Module in Cosmos SDK [x/staking Extending the built-in Module in Cosmos SDK Feb 14, 2025
@golnarmordadi
Copy link
Author

Hi,

I haven’t received a response yet, and we’re in the middle of the implementation. I’d really appreciate it if you could provide an answer.

At the very least, could you confirm whether this is possible?

Thanks!

@alexanderbez

@dev-zaid
Copy link

I'm looking to do the same. Extending the staking module to incorporate nft-staking. Any response would be helpful.

@tac0turtle
Copy link
Member

the design of the staking module is quite tied to the current design, it would be recommended to fork or write your own implementation for staking if it is time sensitive

@dev-zaid
Copy link

the design of the staking module is quite tied to the current design, it would be recommended to fork or write your own implementation for staking if it is time sensitive

I already have forked it. Just can't understand how I can extend it to handle ERC1155 staking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue that needs to be triaged
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants