Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple TokenTransfer{Validation,Execution} from SendPacket{Validation,Execution} #786

Closed
plafer opened this issue Jul 27, 2023 · 1 comment · Fixed by #787
Closed

Decouple TokenTransfer{Validation,Execution} from SendPacket{Validation,Execution} #786

plafer opened this issue Jul 27, 2023 · 1 comment · Fixed by #787
Assignees
@plafer
Labels
O: decoupling Objective: aims to separate concerns and cause to independent, reusable components
Milestone
v0.44.0

Comments

@plafer
Copy link
Contributor

plafer commented Jul 27, 2023

They are currently coupled. However, basecoin shows us that this no longer works, since the TransferModule must know how to send packets, which now requires access to the client validation context (implemented by the core Ibc struct).

Basically, decoupling them just gives us more flexibility; they never needed to be coupled, it was just convenient.
@plafer plafer self-assigned this Jul 27, 2023
This was referenced Jul 27, 2023
Merged
Closed
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 1, 2023
@Farhad-Shabani Farhad-Shabani added the O: decoupling Objective: aims to separate concerns and cause to independent, reusable components label Aug 1, 2023
@Farhad-Shabani
Copy link
Member

I just noticed this issue in essence is the same matter surfaced in #520. That can be closed as well.

@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Aug 4, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.44.0 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
O: decoupling Objective: aims to separate concerns and cause to independent, reusable components
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging a pull request may close this issue.

Decouple TokenTransfer* and SendPacket* informalsystems/ibc-rs
2 participants
@plafer @Farhad-Shabani