Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment warning on invalid expected participant data #476

Open
Whathecode opened this issue Apr 25, 2024 · 0 comments
Open

Add deployment warning on invalid expected participant data #476

Whathecode opened this issue Apr 25, 2024 · 0 comments
Labels
feature New functionality.

Comments

@Whathecode
Copy link
Member

Currently, it is possible to add a protocol with invalid DefaultParticipantAttributes. E.g.,

"attribute": {
        "__type": "dk.cachet.carp.common.application.users.ParticipantAttribute.DefaultParticipantAttribute",
        "inputDataType": "some.type"
      }

As stated elsewhere:

The protocol service does not validate inputDataType. Only when setting the participant data on ParticipationService, errors will occur if no type information is available for the provided inputDataType.

It will be useful to fail early, upon creation of the study protocol in the studies subsystem. This can likely be done by adding a new item to possibleDeploymentIssues.

When considering whether this should be a warning or an error, I believe it should most likely be a warning, keeping flexibility of deploying different versions of CARP subsystems in mind. It can be that the deployment backend has a more recent version than the studies frontend, in which case it could handle study protocols with inputDataType's which are only known on the backend, but not available to the frontend runtime.

@Whathecode Whathecode added the feature New functionality. label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality.
Projects
None yet
Development

No branches or pull requests

1 participant