Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid/incorrect "devices required to register" to obtain deployment for connected devices #490

Open
Whathecode opened this issue Oct 25, 2024 · 0 comments
Labels
bug Something isn't working the way it was designed to.

Comments

@Whathecode
Copy link
Member

DeviceDeploymentStatus contains the following two fields when NotDeployed:

        /**
         * The role names of devices which need to be registered before the deployment information for this device can be obtained.
         */
        abstract val remainingDevicesToRegisterToObtainDeployment: Set<String>

        /**
         * The role names of devices which need to be registered before this device can be declared as successfully deployed.
         */
        abstract val remainingDevicesToRegisterBeforeDeployment: Set<String>

But, DeviceDeploymentStatus is created for all devices in a deployment, including non-primary connected devices. And remainingDevicesToRegisterToObtainDeployment contains the device itself for those (set in StudyDeployment.getDeviceStatus()). This doesn't make sense, since connected devices can't be deployed.

Functionally, this doesn't impact much. However, it does seem confusing and likely misleading.

What is a clean way to fix this? Do devices which can't be deployed need another status? Or, should these fields simply remain unset for non-primary connected devices?

@Whathecode Whathecode added the bug Something isn't working the way it was designed to. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way it was designed to.
Projects
None yet
Development

No branches or pull requests

1 participant