Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPTaskResult does not deserialize RPStepResult in results #83

Closed
jeyjey626 opened this issue Jun 5, 2023 · 2 comments
Closed

RPTaskResult does not deserialize RPStepResult in results #83

jeyjey626 opened this issue Jun 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@jeyjey626
Copy link

When deserializing RPTaskResult, all results in results map are deserialized as RPResult, not RPStepResult, resulting in loss of information.

factory RPTaskResult.fromJson(Map<String, dynamic> json) =>

@bardram bardram self-assigned this Jun 5, 2023
@bardram bardram added the question Further information is requested label Jun 5, 2023
@bardram
Copy link
Contributor

bardram commented Jun 5, 2023

Hi @jeyjey626 - I've looked into this.

The reason why this happens is because the different result objects have never been designed to be de-serialized from JSON into Dart objects. Normally, you would take the Dart result object and serialize it to JSON (using the toJson function) and save it to a file or database.

We never thought that you would need to read this JSON again and de-serialize it back to the app.

So - if I'm to change this, I need to know why you are doing this. What is the use case?

@bardram
Copy link
Contributor

bardram commented Oct 24, 2024

This turned out to be an issue in the carp study app;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants