Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames argument issue #194

Open
jkterry1 opened this issue Jan 7, 2021 · 0 comments
Open

Frames argument issue #194

jkterry1 opened this issue Jan 7, 2021 · 0 comments
Labels
Milestone

Comments

@jkterry1
Copy link
Collaborator

jkterry1 commented Jan 7, 2021

In examples/experiments.py, you consistently refer to max steps as "timesteps". Borrowing from that, I passed the argument timesteps=1e6 in a sample test I was doing, and it turns out the argument is called fames. This is different that what the example makes it seem like, and form the argument to plot_returns_100. Ideally this would be standardized.

@cpnota cpnota added the style label Jan 14, 2021
@cpnota cpnota added this to the Future Work milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants