diff --git a/src/ruis/render/factory.hpp b/src/ruis/render/factory.hpp index 0a7bc105..7159765f 100644 --- a/src/ruis/render/factory.hpp +++ b/src/ruis/render/factory.hpp @@ -104,7 +104,7 @@ class factory virtual utki::shared_ref create_vertex_array( std::vector> buffers, - const utki::shared_ref& indices, + utki::shared_ref indices, vertex_array::mode rendering_mode ) = 0; diff --git a/src/ruis/render/vertex_array.cpp b/src/ruis/render/vertex_array.cpp index 9fb9d977..41f8c2a3 100644 --- a/src/ruis/render/vertex_array.cpp +++ b/src/ruis/render/vertex_array.cpp @@ -27,12 +27,11 @@ using namespace ruis::render; vertex_array::vertex_array( buffers_type buffers, - // NOLINTNEXTLINE(modernize-pass-by-value) - const utki::shared_ref& indices, + utki::shared_ref indices, mode rendering_mode ) : buffers(std::move(buffers)), - indices(indices), + indices(std::move(indices)), rendering_mode(rendering_mode) { if (this->buffers.empty()) { diff --git a/src/ruis/render/vertex_array.hpp b/src/ruis/render/vertex_array.hpp index a5bb46fd..853acd91 100644 --- a/src/ruis/render/vertex_array.hpp +++ b/src/ruis/render/vertex_array.hpp @@ -58,7 +58,11 @@ class vertex_array const mode rendering_mode; protected: - vertex_array(buffers_type buffers, const utki::shared_ref& indices, mode rendering_mode); + vertex_array( + buffers_type buffers, // + utki::shared_ref indices, + mode rendering_mode + ); public: vertex_array(const vertex_array&) = delete; diff --git a/tests/harness/modules/ruis-render-null b/tests/harness/modules/ruis-render-null index 9df06325..599b3cb8 160000 --- a/tests/harness/modules/ruis-render-null +++ b/tests/harness/modules/ruis-render-null @@ -1 +1 @@ -Subproject commit 9df063257d3a71c27cbc757fdfe363e01de1cdc6 +Subproject commit 599b3cb8ba4fad9f28454f3ae80f97e02c0c445d diff --git a/tests/harness/modules/ruisapp b/tests/harness/modules/ruisapp index 3e4a9d46..686fabef 160000 --- a/tests/harness/modules/ruisapp +++ b/tests/harness/modules/ruisapp @@ -1 +1 @@ -Subproject commit 3e4a9d463355827cb216787bd35768c245aa47c2 +Subproject commit 686fabefc9aa0658e1b8ca8ebf8c04d9474da37e