Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text is not user selectable #36

Open
spookylukey opened this issue Apr 9, 2019 · 0 comments · May be fixed by #38
Open

Text is not user selectable #36

spookylukey opened this issue Apr 9, 2019 · 0 comments · May be fixed by #38

Comments

@spookylukey
Copy link

In particular, this seems to be the offending line:

https://github.com/craftpip/angular-confirm/blob/master/css/angular-confirm.less#L69

This means if you use an alert to display any kind of important info, e.g. an error message, users won't be able to copy-paste that text, for example to report the problem, which is not helpful.

I know that I can override this with my own CSS, but libraries should not default to disabling built-in browser behaviour. Thanks!
tomchiverton added a commit to tomchiverton/angular-confirm that referenced this issue Sep 17, 2019
@tomchiverton
enable selecting text : libraries should not default to disabling bui…
abcf615 
…lt-in browser behaviour

Fixes craftpip#36
This was referenced Sep 17, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable selecting text tomchiverton/angular-confirm
1 participant
@spookylukey