Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate attr add behavior should be more intuitive for config file writers, not inherit typical programming semantics #41

Open
viega opened this issue Dec 11, 2022 · 1 comment
Open

Duplicate attr add behavior should be more intuitive for config file writers, not inherit typical programming semantics #41

viega opened this issue Dec 11, 2022 · 1 comment
Labels
p3

Comments

@viega
Copy link
Collaborator

viega commented Dec 11, 2022

No description provided.

@viega
Copy link
Collaborator Author

viega commented Feb 1, 2023

I think the idea here is:

section f {
foo : "bar"
foo : "bar"
}
Should be disallowed, but if a section is reopened, or hit in dot format:
section.f.foo = "bar", that should all be okay.

Not sure about section re-opening, possibly do some flow analysis and warn?

@viega viega added the p2 label Feb 1, 2023
@viega viega added p3 and removed p2 labels Feb 9, 2023
@viega viega changed the title I think I'm not checking for duplicate attr adds properly Duplicate attr add behavior should be more intuitive for config file writers, not inherit typical programming semantics Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viega