Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor ns (ccREL namespace) template as HTML5+RDFa #396

Open
TimidRobot opened this issue Nov 28, 2023 · 11 comments
Open

[Feature] Refactor ns (ccREL namespace) template as HTML5+RDFa #396

TimidRobot opened this issue Nov 28, 2023 · 11 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Nov 28, 2023

Problem

The ccREL namespace (templates/ns.html) template is currently XHTML+RDFa and does not match rest of site (ex. missing header & footer). It is currently a standalone template.

Description

  • Refactor ccREL namespace (templates/ns.html) template so that it:
    1. is HTML+RDFa (HTML 5) instead of XHTML+RDFa (XHTML 4)
    2. extends the base (templates/base.html) template (so that the ccREL namespace page includes the header & footer)
      • This is OPTIONAL as it might signficantly increase the scope of work. If changes to the base template are required, then every template that extends it needs to be checked/verified.

Alternatives

Do nothing

Additional context

@TimidRobot TimidRobot added help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Nov 28, 2023
@pushkar707
Copy link

Hi @TimidRobot , I understand this issue, I would like to work over this. Thankyou

@pushkar707
Copy link

This is how the page looks after extending it to base.html. The layout have changed a bit, but I think it looks better. Is this acceptable:
image

@pushkar707
Copy link

This is the code after changes:-

{% extends 'base.html' %}

{% block title %}Describing Copyright in RDF - Creative Commons Rights Expression Language{% endblock %}
{% block head_meta %}
{% endblock %}

{% block title_header %}

Creative Commons

{% endblock %}

{% block content %}

{% endblock %}

@pushkarDigitWork
Copy link

hi @TimidRobot, can you please check the above comment and screenshot by me and let me know!

Thankyou

@TimidRobot
Copy link
Member Author

@pushkar707 & @pushkarDigitWork I would rather review any changes in a Pull Request (PR) instead of as comments on issues

@BalrajDhakad
Copy link

hey @TimidRobot
This is Balraj,
I want to work on this issue,
can you please tell me what specifically you want to get updated or get fixed.

@TimidRobot
Copy link
Member Author

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

@BalrajDhakad
Copy link

I have already read it but I am not able to get what do you want to say about assigning this issue to me @TimidRobot

@ShivamAhir
Copy link

@BalrajDhakad
If you have followed the guidelines above, you don't need to ask permission to start work on an issue.

@BalrajDhakad
Copy link

BalrajDhakad commented Mar 7, 2024

@ShivamAhir
I have already read the guidelines above and I am already a contributor in CC, please don't mind my words but I am not asking permission to start working on this issue, I am simply asking for more details related to this issue.
You will get it if you will read my last third comment on this issue.

@TimidRobot
Copy link
Member Author

I am simply asking for more details related to this issue.

I updated the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

5 participants