New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled Exception Handling #100

Open

ghost opened this issue Apr 8, 2020 · 0 comments

ghost commented Apr 8, 2020 •

edited by ghost

Loading

Uncaught exceptions seem to cause a connection reset, instead of generating an error response.

Instead, all exceptions without specific error handling code should result in a generic 500 Internal Server Error response.

See #99 for an example.

Edit: According to jnthn this is only the case with exceptions in the request parser

<jnthn> The router makes sure no exceptions leak from application land in such a way (e.g. they become a 500), but if the request parser is unhappy then the router never gets to see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment