Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII URIs don't get encoded #47

Open
Altreus opened this issue Sep 7, 2018 · 1 comment
Open

Non-ASCII URIs don't get encoded #47

Altreus opened this issue Sep 7, 2018 · 1 comment

Comments

@Altreus
Copy link

Altreus commented Sep 7, 2018

Tried to put an emojum in a URI.

      in method panic at /home/altreus/rakudo/rakudo-star-2018.04/install/share/perl6/site/sources/2324DD93FE1564E732D8C179A4652788D7AC67A6 (Cro::Uri) line 173
      in regex URI at /home/altreus/rakudo/rakudo-star-2018.04/install/share/perl6/site/sources/2324DD93FE1564E732D8C179A4652788D7AC67A6 (Cro::Uri) line 27
      in regex TOP at /home/altreus/rakudo/rakudo-star-2018.04/install/share/perl6/site/sources/2324DD93FE1564E732D8C179A4652788D7AC67A6 (Cro::Uri) line 23
      in method parse at /home/altreus/rakudo/rakudo-star-2018.04/install/share/perl6/site/sources/2324DD93FE1564E732D8C179A4652788D7AC67A6 (Cro::Uri) line 313
      in method request at /home/altreus/rakudo/rakudo-star-2018.04/install/share/perl6/site/sources/BD9BD084131C6E7D2BF4FE09570E5EBE604DB8FA (Cro::HTTP::Client) line 327
      in method post at /home/altreus/rakudo/rakudo-star-2018.04/install/share/perl6/site/sources/BD9BD084131C6E7D2BF4FE09570E5EBE604DB8FA (Cro::HTTP::Client) line 298
      in method send at /home/altreus/src/p6-api-discord/lib/API/Discord/HTTP.pm6 (API::Discord::HTTP) line 68
      in method create at /home/altreus/src/p6-api-discord/lib/API/Discord/HTTP.pm6 (API::Discord::HTTP) line 111
      in method add-reaction at /home/altreus/src/p6-api-discord/lib/API/Discord/Message.pm6 (API::Discord::Message) line 127
      in block  at examples/autostar.p6 line 12
      in block  at /home/altreus/src/p6-api-discord/lib/API/Discord.pm6 (API::Discord) line 172
      in method handle-opcode at /home/altreus/src/p6-api-discord/lib/API/Discord/Connection.pm6 (API::Discord::Connection) line 143
      in block  at /home/altreus/src/p6-api-discord/lib/API/Discord/Connection.pm6 (API::Discord::Connection) line 126

Associated code exists in https://github.com/shuppet/p6-api-discord/

@Altai-man
Copy link
Member

Thanks for notifying!

It seems we need to use IDNA::Punycode for some URI parts, therefore patch the grammar too. It's a bit complicated, as we want to extract an exact segment part to correctly apply conversion on it, while we have not parsed URI fully yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants