Misleading errors when using CompositeConnectionDetails

[jtucci]

What happened?

I defined the following CompositeConnectionDetails resource

apiVersion: meta.gotemplating.fn.crossplane.io/v1alpha1
kind: CompositeConnectionDetails
{{ if eq $.observed.resources nil }}
data: {}
{{ else }}
data:
  {{ $redisCacheMR := get .observed.resources "redis-cache" | default dict }}
  {{ $connectionString := dig "connectionDetails" "attribute.primary_connection_string" "" $redisCacheMR }}
  {{ $host := dig "status" "atProvider" "hostname" " " $redisCacheMR }}
  connection_string: {{ $connectionString }}
  host: {{ $host | b64enc }}
{{ end }}

When all the MR's successfully reached a ready state, the claim would fail with the following error.

cannot propagate connection details from composite: cannot establish
control of existing connection secret

This error was resolved by adding quotes to the host host parameter.

...
  host: {{ $host | quote | b64enc }}
 ...

This error was extremely misleading and I'm assuming thats because there's no error handling in the portion of this function which sets connection details. I'm unsure if its feasible but It might be useful to make this a little more robust by automatically quoting / encode values which aren't already in the correct format or outputting an error message.

How can we reproduce it?

set

What environment did it happen in?

Function version: v0.3.0
crossplane: v1.14.2
k8s: 1.26.9

[phclark]

I feel like, since the only Resource associated with CompositeConnectionDetails is the Composition itself, that errors generating the connection details should cause a Composition to not go into the Synced status, and the error message should populate the Synced condition message. Thoughts on this approach?