Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

feat(elbv2): added examples and add more elbv2 resources #211

Closed
wants to merge 1 commit into from
Closed

feat(elbv2): added examples and add more elbv2 resources #211

wants to merge 1 commit into from

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jul 4, 2022 •
edited
Loading

Signed-off-by: haarchri [email protected]

Description of your changes

added examples for elbv2 group
added LBListenerCertificates as new resource
added LBListenerRule as new resource
fixed the following issues for lateInit fields:

Warning  CannotObserveExternalResource  8m30s (x15 over 18m)  managed/elbv2.aws.jet.crossplane.io/v1alpha2, kind=lb  cannot run refresh: refresh failed: Missing required argument: The argument "bucket" is required, but no definition was found.: File name: main.tf.json

LBTargetGroup.elbv2.aws.jet.crossplane.io "sample-lambda-targetgroup" is invalid: spec.forProvider.stickiness.type: Required value

Fixes #212 #213

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                                                 READY   SYNCED   EXTERNAL-NAME                                                                                                                       AGE
lbtargetgroupattachment.elbv2.aws.jet.crossplane.io/sample-target-group-attachment   True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:targetgroup/sample-ip-targetgroup/777905e42026c737-20220704201004536400000001   5d17h

NAME                                        READY   SYNCED   EXTERNAL-NAME                                                                                      AGE
lb.elbv2.aws.jet.crossplane.io/sample-alb   True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:loadbalancer/app/sample-alb/80190b7fdb4d9ea4   5d16h

NAME                                                        READY   SYNCED   EXTERNAL-NAME                                                                                                   AGE
lblistener.elbv2.aws.jet.crossplane.io/sample-lb-listener   True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:listener/app/sample-alb/80190b7fdb4d9ea4/4d0fa52967f671a7   26m

NAME                                                                    READY   SYNCED   EXTERNAL-NAME                                                                                                  AGE
lbtargetgroup.elbv2.aws.jet.crossplane.io/sample-instance-targetgroup   True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:targetgroup/sample-instance-targetgroup/e1d614cd99f579da   5d18h
lbtargetgroup.elbv2.aws.jet.crossplane.io/sample-ip-targetgroup         True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:targetgroup/sample-ip-targetgroup/777905e42026c737         5d18h
lbtargetgroup.elbv2.aws.jet.crossplane.io/sample-lambda-targetgroup     True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:targetgroup/sample-lambda-targetgroup/86df605ec3b306f0     5d18h

NAME                                                                 READY   SYNCED   EXTERNAL-NAME                                                                                                                         AGE
lblistenerrule.elbv2.aws.jet.crossplane.io/sample-lb-listener-rule   True    True     arn:aws:elasticloadbalancing:us-west-1:xxx:listener-rule/app/sample-alb/80190b7fdb4d9ea4/4d0fa52967f671a7/7e2aa241e90785a7   2m15s

@haarchri haarchri mentioned this pull request Jul 4, 2022
Closed
2 tasks
@haarchri haarchri marked this pull request as ready for review July 10, 2022 14:02
@haarchri haarchri mentioned this pull request Jul 14, 2022
Merged
2 tasks
@haarchri
Copy link
Member Author

added a preview image from master(4828ea6) + #198 + #211 +#208 available under: haarchri/provider-jet-aws:v0.5.0-preview

@haarchri haarchri mentioned this pull request Jul 14, 2022
Closed
2 tasks
@haarchri
Copy link
Member Author

haarchri commented Nov 1, 2022

i will close this PR

@haarchri haarchri closed this Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elbv2 CannotObserveExternalResource The argument "bucket" is required
1 participant
@haarchri