From 6819b2b555788cd5280539846e396a10f0102833 Mon Sep 17 00:00:00 2001 From: Moritz Johner Date: Fri, 26 Jan 2024 12:22:47 +0100 Subject: [PATCH] fix: NodePool should not late-init node count The nodepool's node_count and initial_node_count should not be late-initialized to prevent a fight with the GKE autoscaler. Signed-off-by: Moritz Johner --- apis/container/v1beta1/zz_generated_terraformed.go | 2 ++ config/container/config.go | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/apis/container/v1beta1/zz_generated_terraformed.go b/apis/container/v1beta1/zz_generated_terraformed.go index 92e2f02da..2eab88014 100755 --- a/apis/container/v1beta1/zz_generated_terraformed.go +++ b/apis/container/v1beta1/zz_generated_terraformed.go @@ -264,6 +264,8 @@ func (tr *NodePool) LateInitialize(attrs []byte) (bool, error) { return false, errors.Wrap(err, "failed to unmarshal Terraform state parameters for late-initialization") } opts := []resource.GenericLateInitializerOption{resource.WithZeroValueJSONOmitEmptyFilter(resource.CNameWildcard)} + opts = append(opts, resource.WithNameFilter("InitialNodeCount")) + opts = append(opts, resource.WithNameFilter("NodeCount")) li := resource.NewGenericLateInitializer(opts...) return li.LateInitialize(&tr.Spec.ForProvider, params) diff --git a/config/container/config.go b/config/container/config.go index 1c4b5241a..bfa831dc5 100644 --- a/config/container/config.go +++ b/config/container/config.go @@ -130,6 +130,12 @@ func Configure(p *config.Provider) { //nolint:gocyclo Type: "Cluster", Extractor: common.ExtractResourceIDFuncPath, } + r.LateInitializer = config.LateInitializer{ + IgnoredFields: []string{ + "node_count", + "initial_node_count", + }, + } r.TerraformCustomDiff = func(diff *terraform.InstanceDiff, _ *terraform.InstanceState, _ *terraform.ResourceConfig) (*terraform.InstanceDiff, error) { if diff == nil || diff.Destroy {