Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase thoroughness of Provider conformance tests #10

Open
4 of 8 tasks
negz opened this issue May 3, 2021 · 4 comments
Open
4 of 8 tasks

Increase thoroughness of Provider conformance tests #10

negz opened this issue May 3, 2021 · 4 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@negz
Copy link
Member

negz commented May 3, 2021

What problem are you facing?

This repository should define two conformance test suites; one for Crossplane distributions and another for Crossplane providers.

How could conformance help solve your problem?

It could flesh out the provider conformance test suite, which currently exists but has no meaningful tests. We should test that:

  • Providers install only cluster scoped CRDs.
  • Providers install only CRDs that appear to be a managed resource or a provider config.
  • Providers install support for at least one managed resource.
  • All defined resources are in the "crossplane" category, and managed resources are in the "managed" category.
  • A ProviderConfigUsage exists for each extant (managed resource, provider config) tuple.
  • All managed resources can become 'ready'.
  • All managed resources emit Kubernetes events.
  • All managed resources write connection secrets (though for many these secrets would be empty).

(Edit: consolidated some of the comments below into a checklist here).

@negz negz added the enhancement New feature or request label May 3, 2021
@negz
Copy link
Member Author

negz commented May 3, 2021

It's not clear to me whether we should (and how we would) test how managed resources actually behave, given that we don't know which managed resources a provider defines. We could consider requiring that one of each kind of managed resource supported by the provider be created (manually) before the conformance suite is run. This would allow us to test that all managed resources defined by the provider:

  • Can become 'ready'.
  • Emit Kubernetes events.
  • Can write connection secrets (though for many these secrets would be empty).

@negz
Copy link
Member Author

negz commented May 7, 2021

Some other things we'll want to test:

  • All defined resources are in the "crossplane" category, and managed resources are in the "managed" category.
  • A ProviderConfigUsage exists for each extant (managed resource, provider config) tuple.

@negz negz changed the title Test providers for conformance Increase thoroughness of Provider conformance tests May 11, 2021
@negz
Copy link
Member Author

negz commented May 13, 2021

I'm somewhat skeptical WRT testing for event emittance, just because if there's a bunch going on in an API server it's possible for events to expire and disappear pretty quickly. This may not be an issue given that we don't really expect folks to be testing for conformance using a live Kubernetes cluster.

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant