Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading credentials #139

Closed
negz opened this issue May 22, 2024 · 3 comments · Fixed by #140
Closed

Support loading credentials #139

negz opened this issue May 22, 2024 · 3 comments · Fixed by #140
Labels
enhancement New feature or request

Comments

@negz
Copy link
Member

negz commented May 22, 2024

What problem are you facing?

Crossplane v1.16 added support for passing credentials to secrets - crossplane/crossplane#5543.

How could Crossplane help solve your problem?

This SDK should update its protobufs (at least) and potentially add helper utils to get those credentials.

@negz negz added the enhancement New feature or request label May 22, 2024
@TerjeLafton
Copy link

@negz
Composition functions are really amazing, and I find myself using this SDK every time I have to write a composition.

As this SDK is very tightly coupled with the rest of Crossplane, would it be a good idea to version it like the rest too?
So when this gets updated to support the new fields from 1.16, that should be the 1.16 release of this SDK.

It should probably also be maintained with Crossplane too. Upgrading to Crossplane 1.16 now and then realize the SDK does not support it is unfortunate.

@negz
Copy link
Member Author

negz commented May 30, 2024

@TerjeLafton Sure, it's a good idea. Unfortunately this is a large project with few maintainers, and I haven't had time to cut a release yet.

If you're interested in becoming a maintainer on this repo to help with this kind of things, it would be appreciated.

@negz
Copy link
Member Author

negz commented May 30, 2024

As this SDK is very tightly coupled with the rest of Crossplane, would it be a good idea to version it like the rest too? So when this gets updated to support the new fields from 1.16, that should be the 1.16 release of this SDK.

I don't think it's that tightly coupled, actually. It needs a new release when new features are added to functions but I don't think every new Crossplane release will warrant a new SDK release.

@clementblaise clementblaise mentioned this issue Jun 3, 2024
2 tasks
@negz negz closed this as completed in #140 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants