feat: Add Credentials #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @clementblaise, please sign your commit, as the DCO pipeline suggests. Documentation can be found in the contribution process. |
|
@negz , any chance this can be prioritized? Sad to have the new crossplane release out, but not being able to utilize it. |
|
Thanks @JonasKs I am aware. I just got started, which is why it is still a draft. I intend to squash and sign off once I tested it |
negz
reviewed
May 28, 2024
negz
reviewed
May 30, 2024
negz
reviewed
Jun 3, 2024
There was a problem hiding this comment.
A few suggestions, but this is looking great. Thanks @clementblaise!
Signed-off-by: Clément Blaise <[email protected]>
Signed-off-by: Clément Blaise <[email protected]>
Signed-off-by: Clément Blaise <[email protected]>
Signed-off-by: Clément Blaise <[email protected]>
Co-authored-by: Nic Cope <[email protected]> Signed-off-by: Clément Blaise <[email protected]>
Co-authored-by: Nic Cope <[email protected]> Signed-off-by: Clément Blaise <[email protected]>
negz
reviewed
Jun 5, 2024
Signed-off-by: Clément Blaise <[email protected]>
|
Thanks for the work on this @clementblaise - can't wait to use it 😊 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #139
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested