Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated GetNumber() method from Crossplane Runtime #58

Closed
stevendborrelli opened this issue Oct 22, 2023 · 1 comment · Fixed by #59
Closed

Use of deprecated GetNumber() method from Crossplane Runtime #58

stevendborrelli opened this issue Oct 22, 2023 · 1 comment · Fixed by #59
Assignees
Labels
bug Something isn't working

Comments

@stevendborrelli
Copy link
Collaborator

What happened?

resource/composite/composite.go uses GetNumber(), which was deprecated and removed from Crossplane runtime In crossplane/crossplane-runtime@11e9468. This causes downstream functions to break if they update their go.mod.

if f64, err := fieldpath.Pave(xr.Object).GetNumber(path); err == nil {

@stevendborrelli stevendborrelli added the bug Something isn't working label Oct 22, 2023
@negz negz self-assigned this Oct 23, 2023
@negz
Copy link
Member

negz commented Oct 23, 2023

Using GetNumber was actually intentional here. See the comment above:

// This is a bit of a hack. Kubernetes JSON decoders will get us a

I didn't consider the fact that it was deprecated though - I think having our own implementation of GetNumber as you've done in #59 makes sense here. Thanks!

@negz negz closed this as completed in #59 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants