Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

In ScopeRef it seems like Kind and Name cause for too much configuration, name should be replaced with properties #312

Open
BBialeckiACR opened this issue Nov 24, 2020 · 2 comments

Comments

@BBialeckiACR
Copy link

Kind in Scope Ref refers to a schema and Name a definition of properties under that schema. Why not just put the properties here like they were in previous versions, what was the rationale for the change.
Kind then refers to the schema and the properties are defined by that schema and the values entered here.
You then get:

scopes:

 scopeRef:

        apiVersion: standard.oam.dev/v1alpha2

        kind: NetworkScope

        parameters:
                 networkId: cool-vpc-network
                 subnetIds:
                      - cool-subnetwork
                      - cooler-subnetwork
                 internetGatewayType: nat
@resouer
Copy link
Contributor

resouer commented Nov 24, 2020

That network scope should be able to be referenced by multiple components. Btw, this issue is more suitable to spec repo.

@BBialeckiACR
Copy link
Author

This was just to show an example. I understand that the scope is referenced by multiple components, and if part of the same application config then scope as listed here works. This is basically how this was prior to the latest version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants