Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExternalName.SetIdentifierArgumentFn return error #25

Open
muvaf opened this issue Jun 24, 2022 · 0 comments
Open

Make ExternalName.SetIdentifierArgumentFn return error #25

muvaf opened this issue Jun 24, 2022 · 0 comments
Labels
codegen enhancement New feature or request v2
Milestone

Comments

@muvaf
Copy link
Member

muvaf commented Jun 24, 2022

What problem are you facing?


SetIdentifierArgumentFn
does not return an error since it's a simple assignment because in most of the cases we need to assign to a top level. However, more advanced functions setting value on a field path have the possibility of failure, which needs to be returned as error rather than panic since that function is called only in runtime - not generation time.

How could Terrajet help solve your problem?

Change the signature to return error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen enhancement New feature or request v2
Projects
None yet
Development

No branches or pull requests

2 participants