Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Type from config.Reference struct #40

Open
muvaf opened this issue Jul 26, 2022 · 0 comments
Open

Remove Type from config.Reference struct #40

muvaf opened this issue Jul 26, 2022 · 0 comments
Milestone

Comments

@muvaf
Copy link
Member

muvaf commented Jul 26, 2022

What problem are you facing?

We now have TerraformName to represent the corresponding resource, hence Type is unnecessary and could be derived from map[string]*config.Resource map.

How could Terrajet help solve your problem?

Make the existing map[string]*config.Resource map available to CRD builder so that it can look up the type name and write to file, hence remove the only usage of the Type field.

@muvaf muvaf added the enhancement New feature or request label Jul 26, 2022
@jeanduplessis jeanduplessis added this to the v2 milestone Oct 18, 2024
@jeanduplessis jeanduplessis modified the milestones: v2, 2.x Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants