Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take action for omitted fields needed for external name before the generation starts #53

Open
muvaf opened this issue Jul 29, 2022 · 0 comments
Labels
codegen enhancement New feature or request v2
Milestone

Comments

@muvaf
Copy link
Member

muvaf commented Jul 29, 2022

What problem are you facing?

ExternalName configuration has a field called OmittedFields that we use to remove the fields that are filled by external name, such as name or cluster_identifier. However, the deletion of those fields from schema happens in CRD generator so other tools who do look-ups in the schema may still see them. For example, example generator has to iterate over r.ExternalName.OmittedFields as well as schema to accurately check whether the field is still there.

How could Terrajet help solve your problem?

I haven't dug into it but we could somehow shift that deletion operation left and keep the schema as the single source of truth regarding what fields exist in the final object.

@muvaf muvaf added the enhancement New feature or request label Jul 29, 2022
@jeanduplessis jeanduplessis added this to the 2.x milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen enhancement New feature or request v2
Projects
None yet
Development

No branches or pull requests

2 participants