Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An exception in compile-assets-timed should fail the build #134

Open
holyjak opened this issue Jan 16, 2020 · 2 comments
Open

An exception in compile-assets-timed should fail the build #134

holyjak opened this issue Jan 16, 2020 · 2 comments

Comments

@holyjak
Copy link
Contributor

holyjak commented Jan 16, 2020

compile-assets-timed shouldn't just catch + log exceptions, it should rethrow them so lein run would fail. As it is now, if the build fails, my build script cannot know it and will deploy the incomplete site, breaking my blog.

Do you agree?

@holyjak
Copy link
Contributor Author

holyjak commented Jan 16, 2020

I see the exception thrown is kind of ugly so I understand the original motivation to hide it. A possible solution would be to modify the generated cryogen.core/-main to catch it and simply (System/exit 1). Or we could add yet one param to compile-assets-timed such as :swallow-errors defaulting to true....

(Having the exception proved very useful in troubleshooting issues, especially the stack trace.)

@lacarmen
Copy link
Member

Agreed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants