You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
compile-assets-timed shouldn't just catch + log exceptions, it should rethrow them so lein run would fail. As it is now, if the build fails, my build script cannot know it and will deploy the incomplete site, breaking my blog.
Do you agree?
The text was updated successfully, but these errors were encountered:
I see the exception thrown is kind of ugly so I understand the original motivation to hide it. A possible solution would be to modify the generated cryogen.core/-main to catch it and simply (System/exit 1). Or we could add yet one param to compile-assets-timed such as :swallow-errors defaulting to true....
(Having the exception proved very useful in troubleshooting issues, especially the stack trace.)
compile-assets-timed
shouldn't just catch + log exceptions, it should rethrow them solein run
would fail. As it is now, if the build fails, my build script cannot know it and will deploy the incomplete site, breaking my blog.Do you agree?
The text was updated successfully, but these errors were encountered: