Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Problem: files under chainlibpy/amino are not compatible with flake8 and mypy configuration #41

Open
macong-cdc opened this issue Feb 4, 2022 · 0 comments
Assignees

Comments

@macong-cdc
Copy link
Collaborator

macong-cdc commented Feb 4, 2022

Once #40 is merged

  1. please change the following configurations in .pre-commit-config.yaml
  2. run pre-commit run --all-files
  3. change relevant files under chainlibpy/amino directory until pre-commit report no errors

configurations in .pre-commit-config.yaml to be changed

  - id: mypy
    # NOTE: this hook does NOT read "files" and "exclude" configs from mypy configuration files
    files: ^chainlibpy/
-    exclude: ^chainlibpy/(generated/|amino/) # TODO to fix type errors in amino directory
+    exclude: ^chainlibpy/generated/

and

\- repo: https://gitlab.com/pycqa/flake8
  rev: 4.0.1
  hooks:
  - id: flake8
    additional_dependencies:
    - flake8-bugbear
-    # TODO FIX chainlibpy/amino/message.py:284:5: A003 class attribute "id" is shadowing a python builtin
-    # when enable flake8-builtins option
-    # - flake8-builtins
+    # - flake8-builtins
    - flake8-comprehensions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants