Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rule versioning #471

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Implement rule versioning #471

wants to merge 16 commits into from

Conversation

Sija
Copy link
Member

@Sija Sija commented Oct 7, 2024 •
edited
Loading

  • Adds Version property to .ameba.yml (optional)
  • Adds Rule::Base#since_version (optional)
  • Adds --up-to-version <VERSION> CLI switch
  • Adds --rule-versions CLI switch
image

Resolves #448
Refs #470, #307

@Sija Sija added the feature label Oct 7, 2024
@Sija Sija self-assigned this Oct 7, 2024
@Sija Sija added this to the next milestone Oct 7, 2024
@devnote-dev
Copy link

devnote-dev commented Oct 7, 2024 •
edited
Loading

ameba -u working great! I have a list of rules and the versions they were added in if you need it, it goes back as far as 1.3.0. All that remains is implementing the warning message. A compile time flag seems best here, I'm not picky about any particular name for it.

@straight-shoota
Copy link
Contributor

straight-shoota commented Oct 7, 2024 •
edited
Loading

Resolves #448

@Sija Sija force-pushed the feature/rule-since-version branch 2 times, most recently from a9f5168 to 4373e4b Compare October 7, 2024 18:28
@Sija
Copy link
Member Author

Sija commented Oct 7, 2024

@devnote-dev I'll go ahead and finalize this PR, merge it and then let's move onto the next points in the following PRs.

@Sija Sija force-pushed the feature/rule-since-version branch from c43feb4 to 1af3092 Compare October 7, 2024 19:22
@Sija Sija marked this pull request as ready for review October 7, 2024 21:45
@Sija Sija requested a review from veelenga October 7, 2024 21:45
veelenga
veelenga approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👏🏻

src/ameba/runner.cr Outdated Show resolved Hide resolved
devnote-dev
devnote-dev suggested changes Oct 8, 2024
View reviewed changes
src/ameba/presenter/rule_versions_presenter.cr Outdated Show resolved Hide resolved
src/ameba/presenter/rule_presenter.cr Show resolved Hide resolved
src/ameba/config.cr Outdated Show resolved Hide resolved
@Sija Sija force-pushed the feature/rule-since-version branch from e65ed53 to 708e970 Compare October 8, 2024 13:29
@Sija Sija force-pushed the feature/rule-since-version branch from 6a8e0c9 to 48507df Compare October 9, 2024 00:59
@Sija Sija force-pushed the feature/rule-since-version branch 2 times, most recently from b139317 to f89a4b0 Compare October 11, 2024 17:33
@Sija Sija force-pushed the feature/rule-since-version branch from d9e994f to 2ceda15 Compare October 14, 2024 14:52
@devnote-dev
Copy link

Is there anything left to be added for this to be merged?

@Sija
Copy link
Member Author

Sija commented Oct 29, 2024

@devnote-dev I'm thinking of making another point-release before switching to 1.7, so until then I want to wait with merging this PR.

@Sija Sija force-pushed the feature/rule-since-version branch 3 times, most recently from cc47787 to 2e62b5d Compare October 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota left review comments

@devnote-dev devnote-dev devnote-dev approved these changes

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
feature
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Avoid annoyance from new rules
4 participants
@Sija @devnote-dev @straight-shoota @veelenga