Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming/BlockParameterName with ignored names #457

Closed
jwoertink opened this issue Apr 10, 2024 · 1 comment · Fixed by #476
Closed

Naming/BlockParameterName with ignored names #457

jwoertink opened this issue Apr 10, 2024 · 1 comment · Fixed by #476
Assignees
@Sija
Labels
false positive

Comments

@jwoertink
Copy link

Related: #453

I have a block parameter that starts with _ indicating that this value is ignored, but since it still has a single letter, Ameba picks it up as a name that shouldn't be used

image

Maybe for this option, if the block parameter starts with _ then Ameba could ignore it regardless of what it's called?
@veelenga
Copy link
Member

veelenga commented Apr 10, 2024 •
edited
Loading

Yes, it can be definitely ignored

@Sija Sija changed the title Naming/BlockParameterName with ignored names Naming/BlockParameterName with ignored names Oct 10, 2024
@Sija Sija mentioned this issue Oct 10, 2024
Merged
@Sija Sija self-assigned this Oct 10, 2024
@Sija Sija removed the bug label Oct 10, 2024
@Sija Sija closed this as completed in #476 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sija Sija

Labels
false positive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore block parameter names starting with _ crystal-ameba/ameba
3 participants
@Sija @jwoertink @veelenga