Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add integration tests for drivers #161

Open
straight-shoota opened this issue Jan 22, 2022 · 2 comments
Open

CI: Add integration tests for drivers #161

straight-shoota opened this issue Jan 22, 2022 · 2 comments

Comments

@straight-shoota
Copy link
Member

It would be nice to have automated integration tests with at least the major driver implementations (the ones mentioned in the readme). This would help us identify issues that only show when actual drivers are used and validates that changes in this shard ensure compatibility with driver implementations.

Inspired by #160

@bcardiff
Copy link
Member

Yes, but sometimes we do need breaking changes. So these should be smoke and optional

@straight-shoota
Copy link
Member Author

I think it might even be a good practice to add compatibility in the drivers first before actually breaking anything. Maybe this won't work well for all cases, but it should work for many.

And we should probably consider some stability guarantees for crystal-db (i.e. a stable 1.0 release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants