From fa2583815e2b60be34778c127d2eae33cf7aa246 Mon Sep 17 00:00:00 2001
From: Julien Portalier <julien@portalier.com>
Date: Sat, 19 Oct 2024 11:34:25 +0200
Subject: [PATCH] Fix failing specs on FreeBSD (#15093)

---
 spec/std/signal_spec.cr            | 24 ++++++++++++++----------
 spec/std/socket/socket_spec.cr     | 23 +++++++++++++----------
 spec/std/socket/udp_socket_spec.cr |  3 +++
 3 files changed, 30 insertions(+), 20 deletions(-)

diff --git a/spec/std/signal_spec.cr b/spec/std/signal_spec.cr
index 969e4dc3d742..e27373e3be21 100644
--- a/spec/std/signal_spec.cr
+++ b/spec/std/signal_spec.cr
@@ -19,44 +19,48 @@ pending_interpreted describe: "Signal" do
   end
 
   {% unless flag?(:win32) %}
+    # can't use SIGUSR1/SIGUSR2 on FreeBSD because Boehm uses them to suspend/resume threads
+    signal1 = {% if flag?(:freebsd) %} Signal.new(LibC::SIGRTMAX - 1) {% else %} Signal::USR1 {% end %}
+    signal2 = {% if flag?(:freebsd) %} Signal.new(LibC::SIGRTMAX - 2) {% else %} Signal::USR2 {% end %}
+
     it "runs a signal handler" do
       ran = false
-      Signal::USR1.trap do
+      signal1.trap do
         ran = true
       end
-      Process.signal Signal::USR1, Process.pid
+      Process.signal signal1, Process.pid
       10.times do |i|
         break if ran
         sleep 0.1.seconds
       end
       ran.should be_true
     ensure
-      Signal::USR1.reset
+      signal1.reset
     end
 
     it "ignores a signal" do
-      Signal::USR2.ignore
-      Process.signal Signal::USR2, Process.pid
+      signal2.ignore
+      Process.signal signal2, Process.pid
     end
 
     it "allows chaining of signals" do
       ran_first = false
       ran_second = false
 
-      Signal::USR1.trap { ran_first = true }
-      existing = Signal::USR1.trap_handler?
+      signal1.trap { ran_first = true }
+      existing = signal1.trap_handler?
 
-      Signal::USR1.trap do |signal|
+      signal1.trap do |signal|
         existing.try &.call(signal)
         ran_second = true
       end
 
-      Process.signal Signal::USR1, Process.pid
+      Process.signal signal1, Process.pid
       sleep 0.1.seconds
       ran_first.should be_true
       ran_second.should be_true
     ensure
-      Signal::USR1.reset
+      signal1.reset
     end
 
     it "CHLD.reset sets default Crystal child handler" do
diff --git a/spec/std/socket/socket_spec.cr b/spec/std/socket/socket_spec.cr
index f4ff7c90972b..65f7ed72a453 100644
--- a/spec/std/socket/socket_spec.cr
+++ b/spec/std/socket/socket_spec.cr
@@ -24,16 +24,19 @@ describe Socket, tags: "network" do
         sock.type.should eq(Socket::Type::DGRAM)
       {% end %}
 
-      error = expect_raises(Socket::Error) do
-        TCPSocket.new(family: :unix)
-      end
-      error.os_error.should eq({% if flag?(:win32) %}
-        WinError::WSAEPROTONOSUPPORT
-      {% elsif flag?(:wasi) %}
-        WasiError::PROTONOSUPPORT
-      {% else %}
-        Errno.new(LibC::EPROTONOSUPPORT)
-      {% end %})
+      {% unless flag?(:freebsd) %}
+        # for some reason this doesn't fail on freebsd
+        error = expect_raises(Socket::Error) do
+          TCPSocket.new(family: :unix)
+        end
+        error.os_error.should eq({% if flag?(:win32) %}
+          WinError::WSAEPROTONOSUPPORT
+        {% elsif flag?(:wasi) %}
+          WasiError::PROTONOSUPPORT
+        {% else %}
+          Errno.new(LibC::EPROTONOSUPPORT)
+        {% end %})
+      {% end %}
     end
   end
 
diff --git a/spec/std/socket/udp_socket_spec.cr b/spec/std/socket/udp_socket_spec.cr
index 113a4ea3cf61..6e4b607b80ea 100644
--- a/spec/std/socket/udp_socket_spec.cr
+++ b/spec/std/socket/udp_socket_spec.cr
@@ -82,6 +82,9 @@ describe UDPSocket, tags: "network" do
       # TODO: figure out why updating `multicast_loopback` produces a
       # `setsockopt 18: Invalid argument` error
       pending "joins and transmits to multicast groups"
+    elsif {{ flag?(:freebsd) }} && family == Socket::Family::INET6
+      # FIXME: fails with "Error sending datagram to [ipv6]:port: Network is unreachable"
+      pending "joins and transmits to multicast groups"
     else
       it "joins and transmits to multicast groups" do
         udp = UDPSocket.new(family)