-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third-party library repositories on Windows CI #14802
Comments
You mean installing the libraries as dependencies from MSYS(2) repos (mingw/ucrt?) to retain compatibility with MSVC? Or to build the libraries in a MSYS(2) environment? |
The latter, as we have always done |
Slightly related: these are precisely the repositories that don't offer CMake support, and our PowerShell build scripts for them hardcode the use of x86-64, so we might have to add ARM64 ourselves (since it turns out ARM64 support isn't that far-off) |
GMP itself actually builds directly under MSYS2's UCRT64 environment using The main problem is GMP doesn't have the equivalent of MPIR's A second problem is some of those crash dumps look really odd:
These are either a natural consequence of GMP's heavy use of assembly, or a warning that we should indeed not mix libraries built with MinGW and MSVC. I haven't checked whether MPIR builds under Cygwin or MSYS2. |
GMP-specific fixes are now available in #15070. |
Our Windows CI workflow tries to use the original library repositories to build Crystal's dependencies whenever possible, but we are still left with a few third-party repos in use:
These all add MSBuild support since their upstreams do not support the MSVC toolchain out of the box. However, they might become unmaintained, tempered, or even deleted, potentially compromising our Windows builds. So I think we need to act:
The text was updated successfully, but these errors were encountered: