From 46520c0f3066f7766167f911c97d3bd622253f13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCller?= Date: Mon, 26 Sep 2022 19:17:00 +0200 Subject: [PATCH 1/2] Add warning about concurrent requests in `HTTP::Client` --- src/http/client.cr | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/http/client.cr b/src/http/client.cr index a819741b728b..80dc3c0fd7ae 100644 --- a/src/http/client.cr +++ b/src/http/client.cr @@ -58,6 +58,8 @@ # client.close # ``` # +# WARNING: The implementation of `HTTP::Client` does not support concurrent requests. +# # ### Compression # # If `compress` isn't set to `false`, and no `Accept-Encoding` header is explicitly specified, From f31c5be351c3a807ed3fadbfae7c2c4dc572bc33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCller?= Date: Tue, 27 Sep 2022 11:58:39 +0200 Subject: [PATCH 2/2] Reword --- src/http/client.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/http/client.cr b/src/http/client.cr index 80dc3c0fd7ae..2fb0cd9d7c45 100644 --- a/src/http/client.cr +++ b/src/http/client.cr @@ -58,7 +58,7 @@ # client.close # ``` # -# WARNING: The implementation of `HTTP::Client` does not support concurrent requests. +# WARNING: A single `HTTP::Client` instance is not safe for concurrent use by multiple fibers. # # ### Compression #