New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import bitwise expression definitions #80

Open

qualterz opened this issue Dec 27, 2022 · 1 comment

qualterz commented Dec 27, 2022 •

edited

Loading

There is need to import bitwise flag definitions: https://github.com/bitcoin-core/secp256k1/blob/01b819a8c7d485fdd3f024d77273f5769d75b2d3/include/secp256k1.h#L191-L214

Currently, any expressions are ignored:

crystal_lib/src/crystal_lib/prefix_importer.cr

Line 21 in c3012aa

return unless value.is_a?(Crystal::NumberLiteral)

Author

qualterz commented Dec 27, 2022

The naive solution I found is to add Crystal::Expressions to the allowed types:

return unless value.is_a?(Crystal::NumberLiteral | Crystal::Expressions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment