Triage mode's slither.db.json not shareable

[RyanRHall]

Triage mode cannot be used by teams to universally ignore warnings because the constructed file, slither.db.json, records the absolute file path of a contract (filename_absolute), which may not be identical on different machines.

Example:

Alice has contracts in folder:
/home/Alice/project/contracts

she uses triage mode to ignore warnings and creates a slither.db.json

Bob tries to use slither but wants to ignore the warnings that Alice has already hid. Bob has contracts in folder:
/home/Bob/project/contracts

Bob runs slither but slither shows all the warnings that Alice hid.

[montyly]

Hi @RyanRHall ,

Thank you for reporting the issue and for the detailed description.

We are going to investigate how to better triage results from different machines.

[RyanRHall]

@montyly this may actually be a non-issue. Turns out one of the machines I was working with was running an older version of slither. I assumed the issue must have been with the file paths in the the db.json. I guess those are not actually used when running slither? Sorry for the confusion!

[moodysalem]

i ran into this issue and thought the same thing was the problem (file paths), imo slither should remember results across versions for the same detectors. is it possible to make the db more lightweight/compatible across versions?

[montyly]

Hi @moodysalem.
Do you have an example to reproduce this behavior?

Slither should be able to filter on different paths, if not there is a bug somewhere.

For example, this works:

$ cat a/test.sol
contract C{
    uint A;
}
$ cp a/test.sol b/test.sol
$ cd a
$ slither test.sol --triage
# add all the results
$ cd ..
$ cp a/slither.db.json .
$ cp a/slither.db.json b/

Now running with cd a; slither test.sol, cd b; slither test.sol, slither a/test.sol, or slither b/test.sol, with all hide the triaged results.