Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startServer optional arguments causes VSCode thread errors #964

Open
stricklandrbls opened this issue Jul 3, 2024 · 1 comment
Open
Labels
bug Something isn't working code quality cross-platform dependencies Pull requests that update a dependency file
Milestone

Comments

@stricklandrbls
Copy link
Collaborator

The startServer api call has the port and host as the only required arguments but when the logFile argument is undefined then VSCode logs extension thread failures to the debug console.

This also seems to have a temporal dependency on the setLogger api call which will also cause the logging thread to fail even if the logFile argument is populated.

Errors Logged

Error: the worker thread exited
	at Worker.T (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:652240)
	at Worker.emit (node:events:514:28)
	at [kOnExit] (node:internal/worker:316:10)
	at Worker.<computed>.onexit (node:internal/worker:228:20)
	at Worker.callbackTrampoline (node:internal/async_hooks:130:17)
[asf.apache-daffodil-vscode]the worker thread exited
Error: the worker has exited
	at e.exports.write (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:655195)
	at [pino.write] (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:856645)
	at constructor.r [as debug] (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:862411)
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:676746
	at Generator.next (<anonymous>)
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:672053
	at new Promise (<anonymous>)
	at o (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:671798)
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:676674
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:677394
	at Generator.next (<anonymous>)
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:672053
	at new Promise (<anonymous>)
	at o (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:671798)
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:676608
	at /home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:677438
	at Generator.next (<anonymous>)
	at i (/home/stricklr/Code/ctc/dfdl/daffodil-vscode/dist/ext/extension.js:33252:671855)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

NOTE: In the last console output there's a reference to, what I'm assuming, the logger library pino.

These errors are repeated about 3 times and are always output following the serverStart call and just before the next debugger step in the extension.

@stricklandrbls stricklandrbls added bug Something isn't working code quality cross-platform dependencies Pull requests that update a dependency file labels Jul 3, 2024
@scholarsmate
Copy link
Member

Ωedit's startServer takes a logConfig, that is a logback configuration file. The code appears to be correct for that.

@scholarsmate scholarsmate added this to the v1.0.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality cross-platform dependencies Pull requests that update a dependency file
Projects
Development

No branches or pull requests

2 participants