Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used ::not-found by mistake (it seems) in focus-in #17

Open
genovese opened this issue Dec 18, 2021 · 0 comments
Open

Used ::not-found by mistake (it seems) in focus-in #17

genovese opened this issue Dec 18, 2021 · 0 comments

Comments

@genovese
Copy link

In focus-in, it looks like you use ::not-found when you mean not-found. (If you mean to use the keyword, then having the not-found parameter would be ... confusing.) This doesn't appear to break any of the examples because you only pass ::not-found in within the library, but it seems worth fixing.

(defn ^:no-doc focus-in [path not-found x]
  (let [v (get-in x path not-found)]
    (if (= v ::not-found)
      (list)
      (list v))))

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant