From dce7fda4f94b3f31a838480bc45e5127274026a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 25 Feb 2025 08:17:00 +0000 Subject: [PATCH] cmd/cue: embed support is no longer experimental MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While the feature can still be disabled via CUE_EXPERIMENT, it's on by default as of v0.12.0 after the proposal was accepted, so it can be safely relied on as a stable feature. Add a reminder for removing the ability to disable this experiment on the v0.14 release. It's likely that the v0.13 release will follow not long after v0.12, so we should give it a few more months before we take away the option to disable the feature. Signed-off-by: Daniel Martí Change-Id: I2a46bcfd8c2bac14c9ad7372faf8828782e728d0 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1209274 Reviewed-by: Roger Peppe Unity-Result: CUE porcuepine TryBot-Result: CUEcueckoo --- cmd/cue/cmd/help.go | 4 ++-- internal/cueexperiment/exp.go | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/cue/cmd/help.go b/cmd/cue/cmd/help.go index 15947eed6ab..63eed67247d 100644 --- a/cmd/cue/cmd/help.go +++ b/cmd/cue/cmd/help.go @@ -252,9 +252,9 @@ Files containing multiple documents cannot be embedded directly. For NDJSON or multi-document YAML files, embed as type=text and use APIs like yaml.Extract to decode as a list. -Note that embedding cue files is not supported at this time. +Note that embedding CUE files is not supported at this time. -Note: support for embed is experimental, and can be disabled via +For the time being, embedding support can still be disabled via CUE_EXPERIMENT=embed=0. For more details and discussion, see the proposal linked from diff --git a/internal/cueexperiment/exp.go b/internal/cueexperiment/exp.go index 0f7f59154c5..b583a53278e 100644 --- a/internal/cueexperiment/exp.go +++ b/internal/cueexperiment/exp.go @@ -16,6 +16,7 @@ var Flags struct { EvalV3 bool // Embed enables file embedding. + // TODO(v0.14): deprecate this flag to forbid disabling this feature. Embed bool `envflag:"default:true"` // DecodeInt64 changes [cuelang.org/go/cue.Value.Decode] to choose