-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenLab package should fetch items from external site RSS feed as scheduled task #347
Comments
I've done some testing on various configurations and I can't reproduce the reported issue. When I activate the external-group-blogs plugin, either manually or via the CBOX plugin installation process, the |
Hi Boone, Can I try to help you reproduce this issue? I see it on two OpenLab sites that I am involved with- oneonta.sunycreate.cloud and geneseo.sunycreate.cloud Currently running CBOX Openlab 1.4.0 Ed |
Perhaps you can provide more info about exactly how you activated external-group-blogs. Can you walk through the process? How was it installed into your environment - via Commons In A Box, or did you install it yourself somehow? How was it activated on the site in question? |
Hi Boone, I don't see a plugin in CBOX Openlab called "external-group-blogs." Just with the default functionality of CBOX OpenLab, I was able to connect external sites, but there was never any cron job that pulled information from those external sites unless we went to a page. Am I missing a plugin that I should install? Does Commons in a Box OpenLab need a helper plugin to use the external blogs feature? Because even without the BuddyPress External Blogs plugin, when creating groups, the option for an external site is available. Is this one of those cases where the plugin wasn't included in the CBOX OpenLab package, but for the full features to work another plugin needs to be installed? |
Thanks for the details, Ed. Reading back through our exchange here and on the commonsinabox.org forum, I think I see a couple source of misunderstanding. You said:
And then you went into some explorations about how WP's cron system works, which I followed up with. But this starting assumption is not, in fact, correct. If you are running the Classic version of CBOX, you have the option to install the external-group-blogs plugin, which does what you describe: uses a WP scheduled event to fetch RSS feeds, and then inserts items from those feeds into the activity feed of the corresponding RSS feed. But the OpenLab package does not do this. It doesn't fetch items on a scheduled task, and it doesn't create RSS-linked activity items, which is why no email notifications are triggered. CBOX OpenLab does have some light feed-fetching, in the form of the 'Recent Posts' widget on a group page when that group is associated with an external blog. See https://github.com/cuny-academic-commons/openlab-theme/blob/524d3ce7b2ac96851c892a8fcbc7e678883b4d01/lib/group-funcs.php#L1832, https://github.com/cuny-academic-commons/cbox-openlab-core/blob/3c917d3e1d3b28d729e78b667068d9649f7fc18c/includes/group-sites.php#L1060, https://github.com/cuny-academic-commons/cbox-openlab-core/blob/3c917d3e1d3b28d729e78b667068d9649f7fc18c/includes/group-sites.php#L1116 But, again, this is just for display under Recent Posts - no activity items are created. I've changed the title of this ticket to reflect this corrected understanding. What you are suggesting, I think, is that the OpenLab package should fetch RSS items and insert into the activity stream, thus triggering email notifications. This is a reasonable feature request. I've added @bree-z and @jennaspevack as watchers to this ticket so that they can weigh in with any thoughts they might have about it. |
Thanks for all this, Ed. You are right - CBOX OpenLab does do what you've described. After fetching from the remote RSS feed, it creates activity items, which is what triggers the email notifications. https://github.com/cuny-academic-commons/cbox-openlab-core/blob/3c917d3e1d3b28d729e78b667068d9649f7fc18c/includes/group-sites.php#L1142 The fetch only takes place in the following two circumstances:
So this is not precisely what you described in your original post - the case of a WP cron job not being run - but it has a similar cause: feeds belonging to a group will only be refreshed when the group is visited, which doesn't happen very often for many groups. Unfortunately, it's not trivial to set up group-specific cron jobs. We could end up overloading the system with scheduled tasks on networks with many such sites. So we might need a central queue for checks. |
Thanks for being patient through the multiple of layers of misunderstanding. The feature request now says what I wanted! |
See https://commonsinabox.org/groups/openlab-help-support/forum/topic/replacing-the-wordpress-cron#post-8858
The text was updated successfully, but these errors were encountered: