Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Settings > Additional Faculty Dropdown doesn't show all faculty member in the OpenLab directory #364

Open
arto-a opened this issue Jul 22, 2021 · 6 comments
Assignees
Labels
Bug OpenLab Issues specifically related to the OpenLab package

Comments

@arto-a
Copy link
Collaborator

arto-a commented Jul 22, 2021

The dropdown for adding additional faculty in the Course Settings page does not display users who are not already members of the course.

URL: https://openlabdev.commonsinabox.org/groups/hegel-and-marx-logical-studies/admin/edit-details/

Screenshot is attached.
Screenshot from 2021-07-22 15-10-09

@bree-z bree-z added Bug OpenLab Issues specifically related to the OpenLab package labels Jul 22, 2021
@bree-z bree-z added this to the 1.3.0 milestone Jul 22, 2021
@bree-z
Copy link

bree-z commented Jul 22, 2021

Hi Boone,

In case it's helpful, I just wanted to add that the dropdown for group invitations shows all users that match whatever is typed in the box.

Also, I was testing in this course: https://openlabdev.commonsinabox.org/groups/summer-2021-course-shared-clone-2/, logged in as breefaculty, and the only member of the course.

When I typed in 'test', no member names appeared. But, after the 'testfaculty' user joined the group, 'testfaculty' appeared when I typed in 'test'.

Thanks!

@boonebgorges
Copy link
Member

What is the desired behavior?

@bree-z
Copy link

bree-z commented Jul 22, 2021

On the OpenLab, all faculty who are members of the OpenLab (not just the course) whose names match, appear in the dropdown, e.g.:

AdditionalFacultyDropdownOL

@boonebgorges
Copy link
Member

Thanks. This feature in CBOX-OL was based on the Group Contact feature from the OpenLab, which is related to but not identical to Additional Faculty. OL's Group Contact behaves the same way: namely, this autocomplete field matches only members of the group. For prior discussion, see http://redmine.citytech.cuny.edu/issues/2033, particularly the comments through 7.

It's not really feasible to do a match of all "faculty" on CBOX-OL, because we can't be sure that the category "faculty" will exist, or if it does, that it will have similar semantics to City Tech. Moreover, the Group Contact feature across all group types is unified under the hood, meaning that a change in the behavior here affects all other group types as well.

So there are a few options:

  1. Do nothing. This means that it will be possible to add all and only group members as Contacts via this mechanism.
  2. Change the behavior so that the autocomplete matches any site member. This will apply to all group types.

@boonebgorges
Copy link
Member

cc @bree-z ^

@bree-z
Copy link

bree-z commented Jul 23, 2021

Thanks Boone. Let's do nothing for now, and we can revisit to see if we want to make a change at a later date.

@bree-z bree-z modified the milestones: 1.3.0, Future Release Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug OpenLab Issues specifically related to the OpenLab package
Projects
None yet
Development

No branches or pull requests

3 participants