Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuddyPress 12.0 compat #458

Open
boonebgorges opened this issue Nov 30, 2023 · 4 comments
Open

BuddyPress 12.0 compat #458

boonebgorges opened this issue Nov 30, 2023 · 4 comments
Assignees
Milestone

Comments

@boonebgorges
Copy link
Member

See boonebgorges/buddypress-group-email-subscription#242, boonebgorges/buddypress-docs#727, boonebgorges/invite-anyone#176 for discussion and prior art.

Note that we might be able to get away with not having a < 12.0 compatibility layer, because the BP version number is controlled by CBOX.

@boonebgorges boonebgorges added this to the 1.5.1 milestone Nov 30, 2023
@boonebgorges boonebgorges self-assigned this Nov 30, 2023
@r-a-y
Copy link
Member

r-a-y commented Nov 30, 2023

For bbPress, see https://bbpress.trac.wordpress.org/ticket/3576 .

Might we have to consider adding the BP Classic plugin?

@boonebgorges
Copy link
Member Author

Good point. We'll probably have to include BP Classic at least for the plugins we don't control.

I still think we should work in our own codebase toward phasing out legacy URL concatenation in favor of BP 12.0, because it will give admins a better experience with slugs, etc.

boonebgorges added a commit that referenced this issue Dec 5, 2023
boonebgorges added a commit that referenced this issue Dec 5, 2023
@boonebgorges boonebgorges modified the milestones: 1.5.1, 1.6.0 Dec 5, 2023
@boonebgorges
Copy link
Member Author

Given that we are going to be releasing in early January, just a few weeks after the release of BP 12.0, I think we should hold off on bumping our BP version past the 11.x series. We'll take a bit more time to update our internals to use BP 12.0's native functions, and also give BP a chance to shake out any issues after the 12.0 release.

boonebgorges added a commit that referenced this issue Apr 26, 2024
boonebgorges added a commit that referenced this issue Apr 26, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Jul 10, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Jul 10, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Jul 10, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Jul 10, 2024
boonebgorges added a commit to cuny-academic-commons/cbox-openlab-core that referenced this issue Jul 10, 2024
boonebgorges added a commit to cuny-academic-commons/cbox-openlab-core that referenced this issue Jul 10, 2024
@boonebgorges
Copy link
Member Author

I've started working on deprecated function calls, but it's very slow going. I have to change URL concatenation in many, many places, and some of these swap-outs are more complex and thus more error-prone than others. Given the state of testing for 1.6.0, I'm going to stop work on this for the current release. I'll pick it back up for the subsequent release.

@boonebgorges boonebgorges modified the milestones: 1.6.0, 1.6.1 Jul 10, 2024
boonebgorges added a commit to cuny-academic-commons/cbox-openlab-core that referenced this issue Jul 11, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Jul 11, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Jul 19, 2024
See cuny-academic-commons/commons-in-a-box#458, cuny-academic-commons#commons-in-a-box#489.
boonebgorges added a commit that referenced this issue Nov 15, 2024
boonebgorges added a commit that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/cbox-openlab-core that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Nov 15, 2024
boonebgorges added a commit to cuny-academic-commons/openlab-theme that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants