Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default Privacy selection during group creation #467

Open
boonebgorges opened this issue Feb 7, 2024 · 3 comments
Open

Remove default Privacy selection during group creation #467

boonebgorges opened this issue Feb 7, 2024 · 3 comments
Labels
Enhancement OpenLab Issues specifically related to the OpenLab package

Comments

@boonebgorges
Copy link
Member

During group creation, you're asked to configure 'Privacy Settings':

Screenshot_2024-02-06_19-43-30

By default, the 'Public' radio button is checked.

To encourage more intentional choices around privacy, we will provide no default value at all. When loading this page, no radio button will be checked.

We'll probably want to add some client-side validation, since the default state of this part of the form will not be valid. We'll piggyback on existing browser validation.

At the moment we're only building this new feature for CBOX OpenLab.

@boonebgorges boonebgorges added Enhancement OpenLab Issues specifically related to the OpenLab package labels Feb 7, 2024
@boonebgorges boonebgorges added this to the 1.6.0 milestone Feb 7, 2024
@boonebgorges
Copy link
Member Author

I've made the change so that no radio button is checked. I added the required attribute to each radio button, so that browser validation ensures that some value is selected before continuing.

A radio with no default value feels odd to me. The HTML spec recommends against it. From https://html.spec.whatwg.org/multipage/input.html#attr-input-required:

To avoid confusion as to whether a radio button group is required or not, authors are encouraged to specify the attribute on all the radio buttons in a group. Indeed, in general, authors are encouraged to avoid having radio button groups that do not have any initially checked controls in the first place, as this is a state that the user cannot return to, and is therefore generally considered a poor user interface.

I'm unsure what else to suggest in its place.

@bree-z
Copy link

bree-z commented Jun 25, 2024

We'd like to revert this change so that the 'Public' radio button is once again checked by default.

Thanks!

@boonebgorges
Copy link
Member Author

Reverted in cuny-academic-commons/openlab-theme@ee0ccd6

I'll move this out of the 1.6.x for future consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement OpenLab Issues specifically related to the OpenLab package
Projects
None yet
Development

No branches or pull requests

2 participants