Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix iOS apps user agent #347

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Oct 16, 2024

part of MBL-540

Changes

  • Updated native methods to receive SDK arguments for package info
  • Updated native iOS SDK initialization to override SdkClient before initializing native iOS SDK
  • Updated TS SDK initialization to pass package info when calling native SDKs for initialization
  • Updated lock files

@mrehan27 mrehan27 self-assigned this Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN: 347.7.0 (28818042)
  • FCM: 347.7.0 (28818042)

@mrehan27 mrehan27 requested a review from Shahroz16 October 16, 2024 10:12
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrehan27 mrehan27 merged commit 9c0f6a7 into feature/cdp-main Oct 16, 2024
9 checks passed
@mrehan27 mrehan27 deleted the rehan/override-user-agent branch October 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants