Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where a single message can load on multiple tabs / windows #76

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

BernardGatt
Copy link
Collaborator

@BernardGatt BernardGatt requested a review from a team as a code owner January 23, 2025 13:52
@stephen-pope-customer-io
Copy link
Contributor

You will need to address the linter error


export async function setMessageLoaded(queueId) {
const messageLoadingLocalStoreName = await getMessageLoadingStateLocalStoreName(queueId);
log(messageLoadingLocalStoreName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this shows up in debug only, right?

Copy link
Collaborator Author

@BernardGatt BernardGatt Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but that needs to go, thanks!

Copy link
Contributor

@stephen-pope-customer-io stephen-pope-customer-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the debug log is fine, this looks good to me.

@BernardGatt BernardGatt merged commit d467a2f into develop Jan 24, 2025
1 check passed
@BernardGatt BernardGatt deleted the feature/duplicate-message branch January 24, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants