From f0fc1a27ebfb69b5d2487dcfd2cf85d021163888 Mon Sep 17 00:00:00 2001 From: Vsevolod Eremenko Date: Wed, 13 Dec 2023 18:17:23 +0100 Subject: [PATCH 1/2] In conversion from musicXML, allow multiple FretIndications and StringIndications for chord. --- music21/musicxml/xmlToM21.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/music21/musicxml/xmlToM21.py b/music21/musicxml/xmlToM21.py index ef09ac222..e5ed22e7c 100644 --- a/music21/musicxml/xmlToM21.py +++ b/music21/musicxml/xmlToM21.py @@ -2873,7 +2873,7 @@ def xmlToChord(self, mxNoteList: list[ET.Element]) -> chord.ChordBase: if type(art) in seenArticulations: continue c.articulations.append(art) - if not isinstance(art, articulations.Fingering): + if not isinstance(art, (articulations.Fingering, articulations.StringIndication, articulations.FretIndication)): seenArticulations.add(type(art)) for exp in n.expressions: if type(exp) in seenExpressions: From 529febb227f5a37477edad8310540577bd227b68 Mon Sep 17 00:00:00 2001 From: Michael Scott Asato Cuthbert Date: Tue, 2 Jan 2024 19:24:34 -1000 Subject: [PATCH 2/2] Fix line too long --- music21/musicxml/xmlToM21.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/music21/musicxml/xmlToM21.py b/music21/musicxml/xmlToM21.py index e5ed22e7c..f1ae782c3 100644 --- a/music21/musicxml/xmlToM21.py +++ b/music21/musicxml/xmlToM21.py @@ -2873,7 +2873,9 @@ def xmlToChord(self, mxNoteList: list[ET.Element]) -> chord.ChordBase: if type(art) in seenArticulations: continue c.articulations.append(art) - if not isinstance(art, (articulations.Fingering, articulations.StringIndication, articulations.FretIndication)): + if not isinstance(art, (articulations.Fingering, + articulations.StringIndication, + articulations.FretIndication)): seenArticulations.add(type(art)) for exp in n.expressions: if type(exp) in seenExpressions: