Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit undo/redo functionality in annotation UI #8873

Open
2 tasks done
zhiltsov-max opened this issue Dec 25, 2024 · 0 comments
Open
2 tasks done

Revisit undo/redo functionality in annotation UI #8873

zhiltsov-max opened this issue Dec 25, 2024 · 0 comments
Labels
enhancement New feature or request ui/ux

Comments

@zhiltsov-max
Copy link
Contributor

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Is your feature request related to a problem? Please describe.

Currently, when creating composite shapes, such as polylines, points, skeletons, polygons, and masks, the user makes several clicks to obtain the final annotation. This is also true for shape editing, where available. Here are several problems:

  • there is are extra keybinds in addition to standard ctrl+z/ctrl+shift+z to remove the last point added. Not sure if there is a keybind to redo the removed point. It's an extra keybind to remember.
  • when a shape is being edited or created (e.g. a mask) pressing ctrl+z/ctrl+shift+z typically leads to some actions outside of the shape being edited. It's possible to make changes on other frames this way. The focus will be moved to that other frame. I may be wrong, but it looks to me more annoying than really useful. A possible use case is that some (temporary) shape was added (removed) on this frame and you're trying to remove-restore it to change some visual conditions during drawing a new one, but it looks like it's should not be solved this way.
  • if a mistake is made during creating (editing) a composite shape (e.g. a mask), you can only redo the last brush action manually or to restart from scratch. Simply undoing the last action would save the time.

Describe the solution you'd like

When creating (editing) a shape, relate undo/redo (ctrl+z/ctrl+shift+z) to this shape editing "session" only.

Behavior:

  • remove/restore the last point added (polygons, polylines, points)
  • remove/restore the last brush move (masks)
  • undo/redo the last point move (polygons, polylines, points, skeleton points, rectangles, cuboids, ellipses)

Describe alternatives you've considered

It's possible to remember actions on the specific shape elements after shape editing, but I'm not sure it's really needed now, because it can be a lot of useless changes to remember from one shape editing. Also, in some cases it's already available.

Additional context

No response

@zhiltsov-max zhiltsov-max added enhancement New feature or request ui/ux labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui/ux
Projects
None yet
Development

No branches or pull requests

1 participant